Skip to content

Test condition tweaks #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Test condition tweaks #113

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
068725c
Reenable backtrace test in bytecode mode with grand dune hack
jmid Jun 2, 2023
a86b6ed
Simplify test condition for native mode
jmid Jun 2, 2023
694f046
Disable backtrace test on Mingw for now
jmid Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions test/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,15 @@
(name backtrace)
(libraries domainslib)
(modules backtrace)
(enabled_if (and (= %{arch_sixtyfour} true) (<> %{architecture} power) (<> %{architecture} s390x))))
;; disabled temporarily on bytecode switches https://github.com/ocaml/dune/issues/7845
(enabled_if (<> %{system} mingw64)) ;; triggers a known issue on mingw https://github.com/ocaml/ocaml/pull/12231
(modes byte native))
;; byte_complete .exes don't include debug+trace info https://github.com/ocaml/dune/issues/7845
;; so on a bytecode switch/platform we build a plain bytecode version w/trace info
;; and rename it to .exe
(rule
(target backtrace.exe)
(action (copy backtrace.bc backtrace.exe))
(enabled_if (and (= %{bin-available:ocamlopt} false) (<> %{system} mingw64))))

(test
(name off_by_one)
Expand All @@ -112,16 +119,14 @@
(name task_one_dep)
(modules task_one_dep)
(libraries qcheck-multicoretests-util qcheck-core qcheck-core.runner domainslib)
(enabled_if (and (= %{arch_sixtyfour} true) (<> %{architecture} power) (<> %{architecture} s390x)))
;; takes forever on bytecode
(enabled_if %{bin-available:ocamlopt}) ;; takes forever on bytecode
(action (run %{test} --verbose)))

(test
(name task_more_deps)
(modules task_more_deps)
(libraries qcheck-multicoretests-util qcheck-core qcheck-core.runner domainslib)
(enabled_if (and (= %{arch_sixtyfour} true) (<> %{architecture} power) (<> %{architecture} s390x)))
;; takes forever on bytecode
(enabled_if %{bin-available:ocamlopt}) ;; takes forever on bytecode
(action (run %{test} --verbose)))

(test
Expand Down