Allow building FLambda parser in Dune #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, I couldn't find a nice way to regenerate `flambda_parser.ml`, etc. conditionally, which is important because it requires not just Menhir but precisely the correct version of Menhir (the same one the library was built with). So one has to change the mode from `fallback` to `promote` manually. But after that, you get all the benefits of `dune build -w` when editing the parser or lexer.
lukemaurer
force-pushed
the
build-parser-with-dune
branch
from
d713d58 to
7c5a15b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, I couldn't find a nice way to regenerate
flambda_parser.ml, etc. conditionally, which is important because itrequires not just Menhir but precisely the correct version of
Menhir (the same one the library was built with). So one has to change
the mode from
fallbacktopromotemanually. But after that, you getall the benefits of
dune build -wwhen editing the parser or lexer.