Reimplement depth variables as variables #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemaurer
added a commit
that referenced
this pull request
Jun 17, 2021
lukemaurer
force-pushed
the
depth-vars-as-vars
branch
from
a7bf516 to
5a59f2c
Compare
lukemaurer
added a commit
that referenced
this pull request
Jun 21, 2021
lukemaurer
force-pushed
the
depth-vars-as-vars
branch
from
5a59f2c to
f219239
Compare
lukemaurer
changed the title
lukemaurer
force-pushed
the
depth-vars-as-vars
branch
2 times, most recently
from
6bdae77 to
e92a5e1
Compare
mshinwell
approved these changes
Jun 25, 2021
Depth variables will now work exactly like variables in most respects. Like a normal variable, a depth variable has a type with an Flambda kind, only the kind must be the new kind `Rec_info` established in #465.
lukemaurer
force-pushed
the
depth-vars-as-vars
branch
from
e92a5e1 to
174a2a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depth variables will now work exactly like variables in most respects.
Like a normal variable, a depth variable has a type with an Flambda
kind, only the kind must be the new kind
Rec_infoestablished in #465.