Refactor of simplify-let-cont #968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
kit-ty-kate
added a commit
to ocaml-flambda/flambda2-opam
that referenced
this pull request
Dec 15, 2022
Ekdohibs
force-pushed
the
refactor-simplify-let-cont
branch
from
7eb5cce to
0ff3401
Compare
Ekdohibs
requested review from
lukemaurer,
lthls,
chambart,
Gbury,
mshinwell and
poechsel
as code owners
Gbury
force-pushed
the
refactor-simplify-let-cont
branch
from
6fceac0 to
0b05fbb
Compare
Ekdohibs
force-pushed
the
refactor-simplify-let-cont
branch
2 times, most recently
from
06016a4 to
2cbb5ae
Compare
Ekdohibs
force-pushed
the
refactor-simplify-let-cont
branch
from
2cbb5ae to
703c1b2
Compare
Ekdohibs
commented
Jan 10, 2023
Gbury
approved these changes
Jan 11, 2023
Co-authored-by: Guillaume Bury <guillaume.bury@gmail.com>
Gbury
approved these changes
Jan 12, 2023
mshinwell
added a commit
that referenced
this pull request
Jan 12, 2023
This reverts commit 93380a5.
Ekdohibs
added a commit
to Ekdohibs/flambda-backend
that referenced
this pull request
Jan 16, 2023
Co-authored-by: Guillaume Bury <guillaume.bury@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request rewrites simplify_let_cont to be cleaner. This is still WIP, especially concerning the handling of invariant parameters of continuations.