Fix CI failure in test for -alloc-check #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xclerc
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
It is actually surprising it ever worked;
perhaps by accident if patdiff is available.
We should maybe force its installation
and its use by dune (--diff-command,
See dune's documentation).
gretay-js
force-pushed
the
fix_test_noalloc_check_in_ci
branch
from
070ddac to
fd85f54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test introduced in #778 (using dune runtest instead of ocamltest) fails on the CI sometimes with flambda2 because of extra spaces introduced in the output. I don't know what it happened. Pushing the same revision again the test passes. Maybe something different in the github ci vm.
This PR tries to hack around it by trimming leading spaces of the output of the test.