Fix inclusion checks for primitives #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm merging now to speed up the roll, but the changes since ocaml-flambda/ocaml-jst#23 should still get review. |
This was referenced May 24, 2022
mshinwell
pushed a commit
that referenced
this pull request
May 24, 2022
ccasin
added a commit
that referenced
this pull request
Jul 26, 2022
ce76e02 flambda-backend: Bugfix for type_application (#746) 44f3afb flambda-backend: PR580 for main branch (#743) b851eaa flambda-backend: Backport first part of ocaml/ocaml PR10498 (#737) fafb4bd flambda-backend: Fix return mode for eta-expanded function in type_argument (#735) c31f6c3 flambda-backend: Fix treatment of functions called [@nontail] (#725) 847781e flambda-backend: Fix build_upstream post-PR703 (#712) bfcbbf8 flambda-backend: Extend Pblock value kind to handle variants (#703) b2cab95 flambda-backend: Merge ocaml-jst a6d6e0e flambda-backend: Merge ocaml-jst 88a4f63 flambda-backend: Use Pmakearray for immutable arrays (#699) eeaa44b flambda-backend: Install an ocamldoc binary (#695) 48d322b flambda-backend: Ensure that GC is not invoked from bounds check failures (#681) 4370fa1 flambda-backend: Review changes of term directory (#602) 65a4566 flambda-backend: Add code coverage using bisect_ppx (#352) 63ab65f flambda-backend: Bugfix for primitive inclusion (#662) 7e3e0c8 flambda-backend: Fix inclusion checks for primitives (#661) 96c68f9 flambda-backend: Speed up linking by changing cmxa format (#607) 1829150 flambda-backend: Bugfix for Translmod.all_idents (#659) git-subtree-dir: ocaml git-subtree-split: ce76e02
lukemaurer
added a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Jul 27, 2022
b7ec31d47 Don't check the names of unprefixed compilation units 4da7b7519 Fix compilation f012913f3 Code review 204fdff1c Fix compilation on Power e7ebe5b11 Code review b3f462cae Temporarily allow `.cinaps` as the name of a compilation unit 01a9585d1 Fix `opttoploop.ml` compilation 2864c3463 Replace `Compilenv.make_symbol` in all archs 96d2760cd Simpler symbols 67b25c1 Merge flambda-backend changes b2cab95 flambda-backend: Merge ocaml-jst a6d6e0e flambda-backend: Merge ocaml-jst 88a4f63 flambda-backend: Use Pmakearray for immutable arrays (ocaml-flambda#699) eeaa44b flambda-backend: Install an ocamldoc binary (ocaml-flambda#695) 48d322b flambda-backend: Ensure that GC is not invoked from bounds check failures (ocaml-flambda#681) 4370fa1 flambda-backend: Review changes of term directory (ocaml-flambda#602) 65a4566 flambda-backend: Add code coverage using bisect_ppx (ocaml-flambda#352) 63ab65f flambda-backend: Bugfix for primitive inclusion (ocaml-flambda#662) 7e3e0c8 flambda-backend: Fix inclusion checks for primitives (ocaml-flambda#661) 96c68f9 flambda-backend: Speed up linking by changing cmxa format (ocaml-flambda#607) 1829150 flambda-backend: Bugfix for Translmod.all_idents (ocaml-flambda#659) git-subtree-dir: ocaml git-subtree-split: b7ec31d4701dd0d3c63b9fa241dac6b983ef84f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inclusion check implementation for primitives assumed that moregen forced modes to be equal, which is no longer the case. Replace it with an implementation that just checks both possible types.