Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recording of call decisions in inlining records #654

Merged
merged 1 commit into from
May 20, 2022
Merged

Fix recording of call decisions in inlining records #654

merged 1 commit into from
May 20, 2022

Conversation

poechsel
Copy link
Contributor

Fixes a few issues related to recording of calls in inlining reports:

  • Reference to decisions made in another place where printed incorrectly
  • When building the inlining tree decisions on calls where registered wrongly and would sometime forget the real decision
  • Decisions for unknown calls where recorded as a reference to another place instead of as unavailable.

@poechsel poechsel requested review from mshinwell and lthls as code owners May 20, 2022 13:50
@mshinwell mshinwell added the flambda2 Prerequisite for, or part of, flambda2 label May 20, 2022
@mshinwell
Copy link
Collaborator

I'm going to approve this because we need to do a roll, but @lukemaurer please review afterwards

@mshinwell mshinwell merged commit 0633af3 into ocaml-flambda:main May 20, 2022
mshinwell pushed a commit that referenced this pull request May 20, 2022
@poechsel @mshinwell
Fix recording of call decisions in inlining records (#654)
9e80f6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshinwell mshinwell mshinwell approved these changes

@lukemaurer lukemaurer lukemaurer approved these changes

@lthls lthls Awaiting requested review from lthls

Assignees
No one assigned
Labels
flambda2 Prerequisite for, or part of, flambda2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poechsel @mshinwell @lukemaurer