Improved handling of calls inside values for inlining reports #626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take the following code sample:
Inlining reports were showing the call to
f
to happen inFoo
while it actually happened underFoo.A
.The reason behind this misreporting was that the scoping information wasn't used when creating
the relative path for a call.
This PR use the location information on the call to build the correct relative path. This is fine
because closure conversion won't inline Lambda terms directly: the inliner is only able to inline
terms that were only visited and does not even try to maintain correct debuginfo -- or histories --
on those.