Tweak logging code of register allocators #3822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xclerc
force-pushed
the
regalloc-logging-indent
branch
from
a005e1c to
f7ff5bd
Compare
spiessimon
reviewed
Apr 8, 2025
spiessimon
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
I think this looks good! Thank you for addressing my comments from the other PR. I did not carefully read over all of the changes here again, given the other PR (and in particular did not do indent/dedent counting).
I talked to @mshinwell, and flambda2 with 03 enabled (but perhaps already as is) should be able to optimize away the with_ constructs that we discussed the other day. If we want to force O3, it can be enabled at the beginning of the file with [@@@ocaml.flambda_o3]. (But feel free to keep the indent/dedent if refactoring it would be too much of a hassle.)
|
(I have made a note to revisit the logging |
gretay-js
pushed a commit
to gretay-js/flambda-backend
that referenced
this pull request
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is essentially a copy of #3775
(not sure what went wrong), where the discussion
will still happen in order to not lose the state
of the conversation.