Pass around "sub_cfg" in Cfg_selectgen #3792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xclerc
approved these changes
Apr 2, 2025
gretay-js
pushed a commit
to gretay-js/flambda-backend
that referenced
this pull request
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly bizarre PR should be a no-op. It adds a new
sub_cfgparameter which, in #3782, will propagate the sub-cfg state which is currently held in thecurrent_sub_cfginstance variable. This reduces the diff to #3782.The next step will be to actually use these parameters to pass around the sub-cfg values even in the version with objects, to further reduce the diff.
(It was unfortunately necessary to update some method signatures in this PR; these changes will be deleted in #3782.)
Includes #3789