Mark Obj_dup as not having effects and handle in Cfg #3766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshinwell
added
bug
mshinwell
force-pushed
the
to-cmm-obj-dup-extra-args
branch
2 times, most recently
from
26ba1f9 to
4f49fdf
Compare
mshinwell
force-pushed
the
to-cmm-obj-dup-extra-args
branch
from
ad67d05 to
547b0a5
Compare
xclerc
approved these changes
Mar 31, 2025
gretay-js
pushed a commit
to gretay-js/flambda-backend
that referenced
this pull request
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks
Obj_dupas not having effects in the primitive translation out of Flambda 2. ThenCfg.can_raise_terminatoris modified to take account of the neweffectspropagation from #3765. The result is that the included test case now passes, whereas before it failed, by virtue ofTo_cmmnot having wrapped theC.extcallforObj_dupwith an extra argument wrapper (such wrapper always being redundant).This PR has to change the C stub
caml_obj_dupso it never has effects: prior to this PR there is a corner case where an exception may be raised, but I think it's fine for this to change to aCAMLassert. Otherwise it is just like an allocation, which never raises (except for asynchronous effects, but that isn't relevant here).Based on #3765, only the second commit here is new.