Skip to content

github ci jobs with debug runtime for macos #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

gretay-js
Copy link
Contributor

Add two new jobs on macos with debug runtime on. Hopefully it'll help us debug the recurring failure in warnings.ml.

@gretay-js gretay-js requested a review from mshinwell-js March 26, 2025 09:48
@gretay-js gretay-js marked this pull request as ready for review March 26, 2025 13:32
@gretay-js gretay-js force-pushed the arm64_ci_debug_runtime branch from 432147e to 1b9cbe5 Compare March 27, 2025 10:50
@mshinwell
Copy link
Collaborator

The runtime4 failure is:

  * frame #0: 0x00000001986ab720 libsystem_kernel.dylib`__pthread_kill + 8
    frame #1: 0x00000001986e3f70 libsystem_pthread.dylib`pthread_kill + 288
    frame #2: 0x00000001985f0908 libsystem_c.dylib`abort + 128
    frame #3: 0x000000010000d31c test_atomic`caml_failed_assert(expr="Is_in_heap(fp)", file_os=<unavailable>, line=681) at misc.c:55:3 [opt]
    frame #4: 0x00000001000155c0 test_atomic`caml_modify(fp=0x000000013f00dff8, val=-1) at memory.c:681:5 [opt]
    frame #5: 0x000000010000d810 test_atomic`caml_atomic_exchange(ref=<unavailable>, v=<unavailable>) at misc.c:278:3 [opt]
    frame #6: 0x0000000100004fc8 test_atomic`camlTest_atomic__entry + 544

@mshinwell
Copy link
Collaborator

This is the part of the test that fails:

let () =
  let r = Atomic.make 0 in
  let cur = Atomic.get r in
  ignore (Atomic.set r (cur + 1), Atomic.set r (cur - 1));
  assert (Atomic.get r <> cur)

@mshinwell
Copy link
Collaborator

This will be fixed by #3761

@gretay-js gretay-js force-pushed the arm64_ci_debug_runtime branch from 1b9cbe5 to 0f927c3 Compare March 28, 2025 15:46
@mshinwell mshinwell merged commit c68db54 into ocaml-flambda:main Mar 31, 2025
24 checks passed
gretay-js added a commit to gretay-js/flambda-backend that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants