Externals Extraction from .cmt Files #3699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccasin
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Looks fine. I did not carefully review the contents of extract_externals/, since it was reviewed elsewhere earlier.
One additional remark: I think it would be good to put either a readme file in that directory or a comment in extract_externals.mli explaning what it is.
If, in the interest of getting this into our next release, you want to address any of these comments in a future PR, that's fine, just merge.
|
I added a readme file that explains the basic usage of the extraction. I would postpone fine tuning the readme to a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a command line tool to the compiler that can be used to extract shape information about the external declarations in
.cmtfiles. The tool is built asextract_externals.opt.The impact on the rest of the compiler from this PR is minimal. To reduce code duplication, the environment reconstruction in
envaux.mlis parameterized by a flag whether it show allow or disallow missing modules in the reconstruction of the environment. Apart from this change, this PR only adds functionality in new files.The externals extraction. The extraction takes as input
.cmtfiles along with a sequence of-I,-H, and-openflags that would be used for compilation. It then outputs a sexp expression that lists the external declarations that it found in the.cmtfiles along with information about their shapes.