Print the offending mod-bounds on mismatch for unsafe crossing #3661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a type is annotated with `[@@unsafe_allow_any_mode_crossing]`, but the mod-bounds on its jkind annotation are different than the mod-bounds on its manifest, report the offending mod-bounds as part of the error message, rather than just reporting that the mod-bounds are different. This is helpful when the definition site of the manifest is far away.
glittershark
requested review from
goldfirere and
riaqn
and removed request for
goldfirere
riaqn
reviewed
Mar 5, 2025
riaqn
approved these changes
Mar 6, 2025
glittershark
deleted the
aspsmith/improve-error-messages-for-unsafe-allow-any
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a type is annotated with
[@@unsafe_allow_any_mode_crossing], but themod-bounds on its jkind annotation are different than the mod-bounds on its
manifest, report the offending mod-bounds as part of the error message, rather
than just reporting that the mod-bounds are different. This is helpful when the
definition site of the manifest is far away.