Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency of trie.ml and leapfrog.ml on Named_ref. #3650

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

Ekdohibs
Copy link
Contributor

@Ekdohibs Ekdohibs commented Mar 4, 2025

This cleans up the code and should make it possible to cleanly move these files in algorithms/.

Copy link
Contributor

@bclement-ocp bclement-ocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks! Just two minor comments.

I am also wondering if we would want to make the cell field of Parameter.t a 'a option ref with_name directly (and remove the name field entirely), but that's probably too nitpicky.

@Ekdohibs Ekdohibs merged commit b584f5f into ocaml-flambda:main Mar 5, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants