Merge atomic counter inc/dec functions and use them consistently #3644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickBarnes
force-pushed
the
unify_atomics
branch
from
f3196f0 to
9082b2c
Compare
NickBarnes
force-pushed
the
unify_atomics
branch
3 times, most recently
from
ff9267b to
6b7c283
Compare
NickBarnes
force-pushed
the
unify_atomics
branch
from
6b7c283 to
e48f791
Compare
mshinwell
approved these changes
Mar 20, 2025
mshinwell
added a commit
that referenced
this pull request
Apr 2, 2025
NickBarnes
added a commit
to NickBarnes/flambda-backend
that referenced
this pull request
Apr 3, 2025
…ml-flambda#3644) Merge atomic counter inc/dec functions and use them consistently.
NickBarnes
added a commit
to NickBarnes/flambda-backend
that referenced
this pull request
Apr 3, 2025
…ml-flambda#3644) Merge atomic counter inc/dec functions and use them consistently.
NickBarnes
added a commit
to NickBarnes/flambda-backend
that referenced
this pull request
Apr 14, 2025
…ml-flambda#3644) Merge atomic counter inc/dec functions and use them consistently.
gretay-js
pushed a commit
to gretay-js/flambda-backend
that referenced
this pull request
Apr 21, 2025
…tly" (ocaml-flambda#3781) Revert "Merge atomic counter inc/dec functions and use them consistently (ocaml-flambda#3644)" This reverts commit f7e9aca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the
flambda-backendversion of ocaml/ocaml#13593, providing a single set of functions for incrementing/decrementing/initialising atomicuintnatcounters, and using them throughout the runtime. A small step towards simplifying and clarifying GC code (the major GC uses the obscurely-namedatomic_fetch_add_verify_ge0extensively, but only for adding or subtracting 1, and the behaviour matched the existingcaml_atomic_refcount_incr/_decr, which was not specific to refcounts).