Skip to content

Reinstate %makearray_dynamic #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Reinstate %makearray_dynamic #3460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
024c118
Pmakearray_dynamic
mshinwell Oct 17, 2024
5626bc9
Merge remote-tracking branch 'flambda-backend/main' into makearray_dy…
mshinwell Jan 10, 2025
a2aa43b
Restrict two tests to runtime5
mshinwell Jan 10, 2025
3d2543f
Fix tests
mshinwell Jan 10, 2025
a7cce9a
Fix tests again
mshinwell Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restrict two tests to runtime5
  • Loading branch information
@mshinwell
mshinwell committed Jan 10, 2025
commit a2aa43bf8b79eec99a67d5de1dd56a6952b23f18
6 changes: 6 additions & 0 deletions testsuite/tests/typing-layouts-arrays/test_ignorable_product_array_2.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
modules = "${readonly_files}";
flambda2;
arch_amd64;
runtime5;
{
flags = "-extension layouts_beta";
bytecode;
Expand All @@ -16,6 +17,11 @@
}
*)

(* This test exhibited intermittent failures with very low probability on
runtime4, and extensive investigation has not found the cause. It is
suspected it might be a problem in the runtime4 GC. So we have restricted
the test to runtime5 at least for now. *)

(* CR mshinwell: enable for arm64 once float32 is available *)

open Gen_product_array_helpers
Expand Down
6 changes: 6 additions & 0 deletions testsuite/tests/typing-layouts-arrays/test_ignorable_product_array_with_uninit_2.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
modules = "${readonly_files}";
flambda2;
arch_amd64;
runtime5;
{
flags = "-extension layouts_beta";
bytecode;
Expand All @@ -16,6 +17,11 @@
}
*)

(* This test exhibited intermittent failures with very low probability on
runtime4, and extensive investigation has not found the cause. It is
suspected it might be a problem in the runtime4 GC. So we have restricted
the test to runtime5 at least for now. *)

(* CR mshinwell: enable for arm64 once float32 is available *)

open Gen_product_array_helpers
Expand Down
Loading