Skip to content

Implement %makearray_dynamic{,_uninit} #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 64 commits into from
Dec 23, 2024
Merged
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
aa8d5b6
Pmakearray_dynamic
mshinwell Oct 17, 2024
0915606
Expanded product array tests - passes in bytecode
ccasin Oct 13, 2024
7344652
Comment
mshinwell Nov 26, 2024
5eb1651
typo
mshinwell Nov 27, 2024
4968ccc
Move tests to beta
mshinwell Dec 3, 2024
232f8ea
Removing beta again
mshinwell Dec 3, 2024
ec03ad8
%arrayblit
mshinwell Nov 26, 2024
97b2448
Run product array tests on native
mshinwell Dec 5, 2024
228cbb0
Fix error message
mshinwell Dec 5, 2024
8e97244
Fix specialization of Parrayblit
mshinwell Dec 5, 2024
4ebb189
XXX
mshinwell Dec 5, 2024
9d32f6c
typo
mshinwell Dec 5, 2024
41d4d21
C stub fixes
mshinwell Dec 5, 2024
41f50ab
initialization has to return the array
mshinwell Dec 5, 2024
a9b108c
Fix blit
mshinwell Dec 6, 2024
0e9f73d
remove unused code
mshinwell Dec 6, 2024
82bb7a7
Restrict unboxed product array tests to x86-64 for now
mshinwell Dec 6, 2024
f0b430d
Test fixes for any_non_null
mshinwell Dec 6, 2024
7a6b493
Code review
mshinwell Dec 6, 2024
6cb2396
Remove unused functions
mshinwell Dec 6, 2024
b200098
Better message for unobvious case
mshinwell Dec 6, 2024
2766387
num_initializers -> num_components
mshinwell Dec 6, 2024
54ab5d3
num_initializers -> num_components in the OCaml code
mshinwell Dec 6, 2024
3d24d94
Promote test
mshinwell Dec 6, 2024
1225685
Pgcignorableproductarray error
mshinwell Dec 9, 2024
f06bd1e
Prim_local
mshinwell Dec 9, 2024
48adb2b
Fixes in Translprim
mshinwell Dec 9, 2024
9d2066d
Add CR
mshinwell Dec 9, 2024
dcec4f2
Add check for makearray_dynamic_uninit array kinds
mshinwell Dec 9, 2024
cd37bd4
Remove XXX and add comment
mshinwell Dec 9, 2024
41ea993
Remove duplicate XXX
mshinwell Dec 9, 2024
f170cf9
Remove XXX
mshinwell Dec 9, 2024
81ce668
Bytecode implementation for %makearray_dynamic_uninit
mshinwell Dec 9, 2024
226609b
Bytecode implementation for %makearray_dynamic_uninit continued
mshinwell Dec 9, 2024
b7279bd
Fix for caml_alloc_local_reserved
mshinwell Dec 9, 2024
19651a5
Resolve XXX about pending actions call
mshinwell Dec 9, 2024
aec24f8
Update comment
mshinwell Dec 10, 2024
f837193
Update [typing-layouts/layout_poly.ml] to reflect current maturity.
ccasin Dec 10, 2024
4bd5859
Add initialization flag
mshinwell Dec 11, 2024
b63bc4b
Remove unnecessary match
mshinwell Dec 11, 2024
8f24731
Rebase fix
mshinwell Dec 11, 2024
602ff51
Add float64 stubs with consistent names
mshinwell Dec 12, 2024
af5e066
Add CR
mshinwell Dec 12, 2024
52093d3
Add CR
mshinwell Dec 12, 2024
313298e
Run scannable product array tests in native
mshinwell Dec 13, 2024
066feb0
Fix mistake in caml_makearray_dynamic_scannable_unboxed_product
mshinwell Dec 13, 2024
99f696d
Fix wrong region insertion
mshinwell Dec 17, 2024
0ef87d0
Rebase fixes
mshinwell Dec 18, 2024
31756e5
Allow %arrayblit at all layouts
mshinwell Dec 18, 2024
69301b8
Move makearray_dynamic_uninit to layouts_beta
rtjoa Dec 15, 2024
c789ec9
Add gen_product_array_helpers tests for %makearay_dynamic_uninit
rtjoa Dec 15, 2024
3afff91
Add unboxed float array test
rtjoa Dec 15, 2024
8213fbb
Test makearray_dynamic_uninit only accepts GC-ignored layouts
rtjoa Dec 15, 2024
12d861b
Generate %makearray_dynamic tests
rtjoa Dec 17, 2024
c4c53a4
Test %arrayblit at all layouts
rtjoa Dec 18, 2024
c135f02
Port runtime changes to runtime4
mshinwell Dec 20, 2024
cf51bc6
Restrict some makearray_dynamic tests to stack allocation mode
mshinwell Dec 20, 2024
a345718
Restrict some makearray_dynamic tests to stack allocation mode, conti…
mshinwell Dec 20, 2024
f3037d3
Try disabling vectorizer in gi CI
mshinwell Dec 20, 2024
13bc848
Add min and max int to bad indices
rtjoa Dec 20, 2024
1061272
Add clarifying comment
rtjoa Dec 20, 2024
b843171
Change XXX to CR
mshinwell Dec 23, 2024
3931428
Fix bounds check overflow
mshinwell Dec 23, 2024
2a692c0
Comment
mshinwell Dec 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused functions
  • Loading branch information
mshinwell committed Dec 23, 2024
commit 6cb2396aafbdff8f0823bbfd38760b58c8c8f01a
19 changes: 0 additions & 19 deletions runtime/array.c
Original file line number Diff line number Diff line change
Expand Up @@ -406,25 +406,6 @@ CAMLprim value caml_floatarray_create_local(value len)
return caml_alloc_local (wosize, Double_array_tag);
}

CAMLprim value caml_floatarray_create_and_initialize(value len, double init)
{
value v = caml_floatarray_create(len);
for (mlsize_t i = 0; i < Long_val(len); i++) {
Store_double_field(v, i, init);
}
return v;
}

CAMLprim value caml_floatarray_create_local_and_initialize(value len,
double init)
{
value v = caml_floatarray_create_local(len);
for (mlsize_t i = 0; i < Long_val(len); i++) {
Store_double_field(v, i, init);
}
return v;
}

/* [len] is a [value] representing number of words or floats */
static value make_vect_gen(value len, value init, int local)
{
Expand Down