Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hiding nullability annotations when pretty-printing #3285

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

dkalinichenko-js
Copy link
Contributor

@dkalinichenko-js dkalinichenko-js commented Nov 18, 2024

Title, to prepare for taking or_null out of alpha. Also stop parsing any as any_non_null.

Accept tests, manually change anys to any_non_nulls when working with arrays.

@mshinwell mshinwell added the or_null Related to or_null layouts label Nov 21, 2024
@dkalinichenko-js dkalinichenko-js force-pushed the dkalinichenko/stop-hiding-non-null branch from 79b0972 to 468bdcb Compare December 5, 2024 20:13
@dkalinichenko-js dkalinichenko-js force-pushed the dkalinichenko/stop-hiding-non-null branch from 468bdcb to ff6aed6 Compare December 5, 2024 20:30
@dkalinichenko-js dkalinichenko-js marked this pull request as ready for review December 5, 2024 20:59
@dkalinichenko-js dkalinichenko-js merged commit aaf4270 into main Dec 5, 2024
20 checks passed
@dkalinichenko-js dkalinichenko-js deleted the dkalinichenko/stop-hiding-non-null branch December 5, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
or_null Related to or_null layouts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants