Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use null pointers for or_null #3267

Merged
merged 19 commits into from
Jan 15, 2025
Merged

Use null pointers for or_null #3267

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7d13d54
runtime changes
d-kalinichenko Dec 5, 2024
5f5f905
runtime4 changes
d-kalinichenko Dec 5, 2024
ce49846
Change `CODE_UNBOXED_INT64` and `CODE_NULL`
d-kalinichenko Dec 9, 2024
66a32ef
make `Is_block` an inline function
d-kalinichenko Dec 9, 2024
7ace827
redefine `Is_long`
d-kalinichenko Dec 9, 2024
6d0d9e4
fix
d-kalinichenko Dec 9, 2024
742477f
Change `CODE_UNBOXED_INT64` back
d-kalinichenko Dec 19, 2024
6bd993e
optimize `Is_block`/`Is_long`
d-kalinichenko Dec 19, 2024
3abb463
`null_tag` for `caml_obj_tag`
d-kalinichenko Dec 19, 2024
44e3f92
consistent naming
d-kalinichenko Dec 19, 2024
6fa2cd2
slightly more reassuring comment
d-kalinichenko Dec 19, 2024
c38a482
`inline` is unnecessary and might break `#define inline`
d-kalinichenko Dec 26, 2024
cb3cb14
optimization incorrect in presence of nulls
d-kalinichenko Jan 15, 2025
d492612
Constructors and pattern-matching
d-kalinichenko Dec 9, 2024
2611c83
Bytecode compilation
d-kalinichenko Dec 9, 2024
9048c56
`or_null` is `Variant_or_null`
d-kalinichenko Dec 9, 2024
09fd56a
Accept tests
d-kalinichenko Dec 9, 2024
1211abb
Runtime tests
d-kalinichenko Dec 9, 2024
c55295c
Delete obsolete or_null test
d-kalinichenko Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change CODE_UNBOXED_INT64 and CODE_NULL
  • Loading branch information
@d-kalinichenko
d-kalinichenko committed Jan 15, 2025
commit ce49846a40d9f132803fe454289af427fee77dd6
5 changes: 3 additions & 2 deletions runtime/caml/intext.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,9 @@
#define OLD_CODE_CUSTOM 0x12 // no longer supported
#define CODE_CUSTOM_LEN 0x18
#define CODE_CUSTOM_FIXED 0x19
#define CODE_UNBOXED_INT64 0x1a
#define CODE_NULL 0x1b

#define CODE_UNBOXED_INT64 0x1f // Jane Street extensions
#define CODE_NULL 0x1e

#if ARCH_FLOAT_ENDIANNESS == 0x76543210
#define CODE_DOUBLE_NATIVE CODE_DOUBLE_BIG
Expand Down
5 changes: 3 additions & 2 deletions runtime4/caml/intext.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,9 @@
#define CODE_CUSTOM 0x12 /* deprecated */
#define CODE_CUSTOM_LEN 0x18
#define CODE_CUSTOM_FIXED 0x19
#define CODE_UNBOXED_INT64 0x1a
#define CODE_NULL 0x1b

#define CODE_UNBOXED_INT64 0x1f // Jane Street extensions
#define CODE_NULL 0x1e

#if ARCH_FLOAT_ENDIANNESS == 0x76543210
#define CODE_DOUBLE_NATIVE CODE_DOUBLE_BIG
Expand Down