Parallelise building dynlink_compilerlibs
#3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This performs two weird tricks that together knock ~30 seconds off the build time in dev mode and ~40 seconds outside dev mode: - To build `dynlink_compilerlibs`, copy both `parser.ml` and `parser.mli` from the main compiler source rather than just `parser.ml`. Copying just `parser.ml` means that the native build depends on the .cmi produced by the bytecode build. - Explicitly add the .cma and .cmxa files for `dynlink` and `flambda2_from_lambda` to the `install` alias. It's not clear why this helps, but it appears that Dune is being excessively lazy in discovering installable targets, waiting until `ocamlcommon` is built before it even considers any targets in these libraries, including those that don't depend on `ocamlcommon` (and take quite a while to build). Redundantly adding targets to `install` seems to be the nudge Dune needs.
|
I am really looking forward to the cleansing fire of ocaml/ocaml#11996 that will arrive with 5.3, but in the meantime this looks great. (Might also be worth asking a Dune person to have a look at why adding |
stedolan
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This performs two weird tricks that together knock ~30 seconds off the build time in dev mode and ~40 seconds outside dev mode:
To build
dynlink_compilerlibs, copy bothparser.mlandparser.mlifrom the main compiler source rather than justparser.ml. Copying justparser.mlmeans that the native build depends on the .cmi produced by the bytecode build.Explicitly add the .cma and .cmxa files for
dynlinkandflambda2_from_lambdato theinstallalias. It's not clear why this helps, but it appears that Dune is being excessively lazy in discovering installable targets, waiting untilocamlcommonis built before it even considers any targets in these libraries, including those that don't depend onocamlcommon(and take quite a while to build). Redundantly adding targets toinstallseems to be the nudge Dune needs.