Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SIMD build on arm64 #3208

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix SIMD build on arm64 #3208

merged 1 commit into from
Oct 30, 2024

Conversation

mshinwell
Copy link
Collaborator

@TheNumbat please approve and merge

@mshinwell mshinwell requested a review from TheNumbat October 30, 2024 16:31
@chambart
Copy link
Contributor

That C code should properly work on mac. The #ifdef should be more general to be active on mac.
But those undefined function should stay there anyway

@TheNumbat
Copy link
Contributor

We made the build system aware of these CAMLprims in #3178, and gen_primitives ignores the #ifdef here, so now the arm64 build expects the symbols to exist. This solution seems fine, and should still work on x86 macos.

@TheNumbat TheNumbat merged commit 21614a5 into ocaml-flambda:main Oct 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheNumbat TheNumbat TheNumbat approved these changes

Assignees
No one assigned
Labels
build system simd SIMD support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshinwell @chambart @TheNumbat