Refactor multi-word array bounds check code #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e73bed1)
TheNumbat
approved these changes
Sep 24, 2024
TheNumbat
reviewed
Sep 24, 2024
middle_end/flambda2/from_lambda/lambda_to_flambda_primitives.ml
Outdated
Show resolved
Hide resolved
TheNumbat
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Refactor multi-word array bounds check code (cherry picked from commit e73bed1) * Special case for width_in_scalars=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactoring-only PR which is needed for #3068 . That PR will make use of the existing logic used for SIMD bounds checks, made more generic in this PR.
(cherry picked from commit e73bed1)