Do not export "fail.h" from "signals.h" in runtime4 #2979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
mshinwell
approved these changes
Aug 27, 2024
mshinwell
deleted the
dvulakh.remove-caml_failwith-export-from-runtime4-signals
branch
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
…caml-flambda#2979) remove [#include "fail.h"] in [runtime4/signals.h] Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"fail.h"is not re-exported in"signals.h"in the OCaml 5 runtime. This PR makes runtime4 consistent in this regard, which will prevent a class of errors in which a C stub compiles when building with runtime4, but not with the OCaml 5 runtime.This can happen, for example, if a stub includes
"signals.h"and callscaml_failwithwithout including"fail.h".Testing: compilation & CI suffices