Zero alloc: rename Checks to Zero_alloc_info
#2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check is enabled by default. Compilation units compiled with and without CMXs are compatible and it is common to have a mix of both even in an unoptimized build, (since removal of closure and flambda2), which makes [enabled] field useless.
xclerc
reviewed
May 16, 2024
xclerc
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabledfield ofChecks.t: the summaries are computed by default and the field is useless for builds that have at least one dependency built with summaries (which is the common case even for non-optimized builds).check.mltozero_alloc_info.mlas a follow up for Zero alloc: refactor to remove "property" and improve naming #2416.