Middle end/backend/runtime changes for or_null #2532
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkalinichenko-js I've just added some more commentary in |
Ekdohibs
reviewed
May 15, 2024
| @@ -737,6 +737,8 @@ let rec layout_union l1 l2 = | |||
| match l1, l2 with | |||
| | Pbottom, l | |||
| | l, Pbottom -> l | |||
| | Pnullable_value value_kind1, Pnullable_value value_kind2 -> | |||
| Pnullable_value (value_kind_union value_kind1 value_kind2) | |||
There was a problem hiding this comment.
Shouldn't we also want a join between Pnullable_value and Pvalue to return something better than Ptop? This is necessary if the layouts are not incompatible.
|
With #2614 merged, we should be able to connect this to the front-end. |
|
Superceded by newer PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be described later; this is mainly here so @dkalinichenko-js can work from it. The
Lambdainterface should be about right.