Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed constructor args #2508

Merged
merged 35 commits into from
May 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
dfeb52a
tmp
ncik-roberts Apr 5, 2024
482b5dd
Update comment and factor out element_repr
ncik-roberts Apr 12, 2024
a3b795b
Implement core of variant code
ncik-roberts Apr 12, 2024
1a6e336
Some progress
ncik-roberts Apr 15, 2024
52e61a9
Get more things working
ncik-roberts Apr 18, 2024
765f94d
Fix some bugs
ncik-roberts Apr 25, 2024
5e4829e
Remove lies about tags being 0
ncik-roberts Apr 25, 2024
4bb4135
Improve and fix bugs in error messages
ncik-roberts Apr 25, 2024
8bc93e8
Update existing tests
ncik-roberts Apr 25, 2024
975b05d
Add constructor args to generated tests
ncik-roberts Apr 26, 2024
2e2f058
make fmt
ncik-roberts Apr 29, 2024
e50ab5b
Restore bytecode test to same size
ncik-roberts Apr 29, 2024
3713ac0
Fix extensible variant bug
ncik-roberts Apr 29, 2024
e3f98c2
Add extensible variant typing tests
ncik-roberts Apr 29, 2024
44dce07
Commit half-failing test
ncik-roberts Apr 29, 2024
eb254bd
chamelon
ncik-roberts Apr 30, 2024
474d747
Fix layout bug and add more tests
ncik-roberts Apr 30, 2024
43b835e
Move a giant chunk of code closer to where it was at the base of this…
ncik-roberts Apr 30, 2024
c41fb76
Fix test generation to do all-float constructors
ncik-roberts Apr 30, 2024
7dd1c16
Fix whitespace in tests + build
ncik-roberts Apr 30, 2024
9017159
Fix upstream build, I hope
ncik-roberts Apr 30, 2024
7a12697
Get rid of layout_field
ncik-roberts Apr 30, 2024
ffa2f50
[make fmt] and remove some straggling layout_fields
ncik-roberts Apr 30, 2024
4cbc424
Remove debug code
ncik-roberts Apr 30, 2024
e957aa0
improve garbled comment
ncik-roberts Apr 30, 2024
926ec76
Add some more tests
ncik-roberts May 2, 2024
e488f02
Refactor inlined record error message to fix infelicity
ncik-roberts May 2, 2024
4369268
Fix rec check
ncik-roberts May 2, 2024
c46d528
rename 'mixed record' to 'mixed product' and fix toplevel printing
ncik-roberts May 2, 2024
e353ced
Add test for recursive mixed blocks
ncik-roberts May 2, 2024
b71c8ed
comment misleading support
ncik-roberts May 3, 2024
43dcfe8
Review: update comment to note dummy value
ncik-roberts May 3, 2024
8dd03de
minor cleanups from review
ncik-roberts May 3, 2024
d5d7b3d
note infelicity in comment
ncik-roberts May 3, 2024
4e4fcd7
Update tests due to shelving of #2504
ncik-roberts May 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve garbled comment
  • Loading branch information
ncik-roberts committed May 6, 2024
commit e957aa0bd98f1660e471c6a64139e037f6f526f9
2 changes: 1 addition & 1 deletion middle_end/flambda2/from_lambda/dissect_letrec.ml
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ let rec prepare_letrec (recursive_set : Ident.Set.t)
args ([], [])
in
(* [arg_layout] is more general than any of the possible layouts of [args]:
- The arguments to [Pmakeblock]/[Pmakearray] are value fields. - The
The arguments to [Pmakeblock]/[Pmakearray] are value fields, and the
argument to [Pduprecord] is a block. *)
let arg_layout = Typeopt.layout_union layout_value_field layout_block in
TheNumbat marked this conversation as resolved.
Show resolved Hide resolved
(* Bytecode evaluates effects in blocks from right to left, so reverse defs
Expand Down