Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable stack checks by default #2404

Merged
merged 18 commits into from
May 9, 2024
Merged

Disable stack checks by default #2404

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f099a54
Disable stack checks by default.
xclerc May 2, 2024
7b1e5ec
Actually disable the checks.
xclerc May 3, 2024
44d8eb1
Review
xclerc May 3, 2024
d09153c
Make the build fail if stack checks are disabled but POSIX signals ar…
xclerc May 6, 2024
c474cd1
Abort if trying to reallocate the stack when stack checks are disabled.
xclerc May 6, 2024
f8c3886
Emit stack checks for probes (#2539)
xclerc May 7, 2024
9e4feb5
Force stack check to be enabled on arm64.
xclerc May 7, 2024
0663925
Make sure mmap and others are available when stack checks are disabled.
xclerc May 7, 2024
35bdee9
Correct arm64 check
mshinwell May 7, 2024
f77a829
Long line
mshinwell May 7, 2024
4b40c31
Increase main stack size in case of getrlimit failure
mshinwell May 7, 2024
04a23c6
Missing Wsize_bsize
mshinwell May 7, 2024
110591d
Don't assume mmap returns a page-aligned block.
xclerc May 8, 2024
f5a97d9
Ensure stack check are properly disabled on the non-CFG path.
xclerc May 8, 2024
f2107cf
Cosmetic changes; remove unnecessary label
mshinwell May 9, 2024
47a11f6
Stack computations
mshinwell May 9, 2024
e4b394a
Fix build.
xclerc May 9, 2024
80411fc
Fix build.
xclerc May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make the build fail if stack checks are disabled but POSIX signals ar… 
…e not available.
  • Loading branch information
@xclerc
xclerc committed May 7, 2024
commit d09153c0f9fc28f381bd6d280924dc74ea32aae7
8 changes: 6 additions & 2 deletions ocaml/runtime/signals_nat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,19 @@ void caml_garbage_collection(void)
}
}

#if defined(NATIVE_CODE) && !defined(STACK_CHECKS_ENABLED)

#if !defined(POSIX_SIGNALS)
#error "stack checks cannot be disabled if POSIX signals are not available"
#endif

#define DECLARE_SIGNAL_HANDLER(name) \
static void name(int sig, siginfo_t * info, ucontext_t * context)

#define SET_SIGACT(sigact,name) \
sigact.sa_sigaction = (void (*)(int,siginfo_t *,void *)) (name); \
sigact.sa_flags = SA_SIGINFO

#if defined(NATIVE_CODE) && !defined(STACK_CHECKS_ENABLED)

CAMLextern void caml_raise_stack_overflow_nat(void);

DECLARE_SIGNAL_HANDLER(segv_handler)
Expand Down