Rework jkind default #2158
Merged
Rework jkind default #2158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanechang
force-pushed
the
aec/rework-jkind-default
branch
2 times, most recently
from
ae288cf to
b056c36
Compare
|
This follows #2107 and reworks how type variables get their jkinds. Prior to #2107, type variables start with jkind #2107 passes the tests by changing type variables to all start with concrete jkinds. This PR makes the type variable jkind initialization controllable through a new field in The general rule it follows is that
This PR also contains a change to How to reviewMight be best to first review the changes in |
goldfirere
reviewed
Dec 14, 2023
There was a problem hiding this comment.
A few changes requested on choices of policy.
I did not review testsuite changes, as I wish to review them in #2107.
alanechang
added a commit
that referenced
this pull request
Dec 19, 2023
* extend policy to control ty var jkind init * annotation on type vars should be upper bounds * proper jkind reason * sort init rhs of constraints for backward compatibility * add comment&rename to jkind_initialization_choice * refactor policy * comment about transl_simple_type_delayed * use Any more in typeclass * add new_var_jkind param and thread it through * use Any for with constraint * add note * more tests * more tests
goldfirere
added a commit
that referenced
this pull request
Dec 27, 2023
* wip * change Wildcard and Unification_var to sort vars * test changes * more tests * fix test * test changes * Rework jkind default (#2158) * extend policy to control ty var jkind init * annotation on type vars should be upper bounds * proper jkind reason * sort init rhs of constraints for backward compatibility * add comment&rename to jkind_initialization_choice * refactor policy * comment about transl_simple_type_delayed * use Any more in typeclass * add new_var_jkind param and thread it through * use Any for with constraint * add note * more tests * more tests * rebase over type var print order change * Add a bunch of tests * check instead of constrain * jkind check in unify_univar * update test outputs * change unify_univar to take jkinds * Testing representability of function argument * More tests * Yet more tests * Accept test output * Propagate new test to _alpha * More tests, this time about inference * add tests to _alpha * small test changes * relax approx_type * reword history message * add cr for bad error message * fix test * rename layout to jkind * add comments about check_type_jkind_exn * add comment about unify_univar invariant --------- Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com>
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
…a#2107) * wip * change Wildcard and Unification_var to sort vars * test changes * more tests * fix test * test changes * Rework jkind default (ocaml-flambda#2158) * extend policy to control ty var jkind init * annotation on type vars should be upper bounds * proper jkind reason * sort init rhs of constraints for backward compatibility * add comment&rename to jkind_initialization_choice * refactor policy * comment about transl_simple_type_delayed * use Any more in typeclass * add new_var_jkind param and thread it through * use Any for with constraint * add note * more tests * more tests * rebase over type var print order change * Add a bunch of tests * check instead of constrain * jkind check in unify_univar * update test outputs * change unify_univar to take jkinds * Testing representability of function argument * More tests * Yet more tests * Accept test output * Propagate new test to _alpha * More tests, this time about inference * add tests to _alpha * small test changes * relax approx_type * reword history message * add cr for bad error message * fix test * rename layout to jkind * add comments about check_type_jkind_exn * add comment about unify_univar invariant --------- Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.