Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Linearize Pass #2020

Merged
merged 5 commits into from
Dec 14, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comments
  • Loading branch information
gretay-js committed Nov 13, 2023
commit cacc11b6029dcde0eb37d70be69fad591fdf7a72
6 changes: 1 addition & 5 deletions backend/cfg/cfg.mli
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,7 @@ val print_instruction :
exception handling. It has a lot of redundancy and the result of the
computation is not used.

Redundancy: linear_to_cfg reconstructs intraprocedural exception handling
stacks from linear IR and annotates each block with this information.
However, CFG instructions still include the original push/poptraps from
Linear.

CFG instructions still include push/poptraps.
To remove these push/poptraps from CFG IR, we need to split blocks at every
push/poptrap. Then, we can annotate the blocks with the top of the trap
stack, instead of carrying the copy of the stack. *)
Expand Down
3 changes: 1 addition & 2 deletions backend/cfg/cfgize.ml
Original file line number Diff line number Diff line change
Expand Up @@ -784,8 +784,7 @@ let fundecl :
fun_contains_calls;
(* CR-someday mshinwell: [fun_poll] will need to be propagated in the
future, e.g. when writing a [Polling] equivalent on [Cfg]. We don't
do this at present since there is no need, and because
[Linear_to_cfg] doesn't have [fun_poll] available. *)
do this at present since there is no need. *)
fun_poll = _
} =
fundecl
Expand Down