Allow unboxing to detect and delete dead code #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekdohibs
reviewed
Aug 3, 2023
|
@chambart ping on review please |
|
@chambart ping, ^^ |
|
@Ekdohibs will review |
Ekdohibs
approved these changes
May 27, 2024
Ekdohibs
reviewed
May 27, 2024
Gbury
force-pushed
the
invalid_after_unboxing
branch
from
c4c1834 to
bca77af
Compare
chambart
reviewed
May 28, 2024
middle_end/flambda2/simplify/unboxing/unbox_continuation_params.ml
Outdated
Show resolved
Hide resolved
mshinwell
added a commit
that referenced
this pull request
Jun 13, 2024
This reverts commit 1a58792.
mshinwell
added a commit
that referenced
this pull request
Jun 13, 2024
This reverts commit 1a58792.
mshinwell
added a commit
that referenced
this pull request
Jun 13, 2024
TheNumbat
pushed a commit
that referenced
this pull request
Jun 21, 2024
Ekdohibs
added a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
Invalidwhen rewriting it (instead of adding params/args)This improves on the example from #1578 , and flambda2 is now able to eliminate the dead code of the gadt pattern match after inlining.
@chambart should review to ensure that all of the invalids encountered during unboxing are indeed invalids and not poison situations (and a round of testing on opam packages before merging would be useful).