Skip to content

Use effects and coeffects of Cextcall in selectgen #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 29, 2021
Merged

Use effects and coeffects of Cextcall in selectgen #16

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
095d5b3
Use effects and coeffects in selectgen.
gretay-js Apr 27, 2021
93622e1
Remove the constraint builtin=true
gretay-js Apr 28, 2021
891f88b
Update comment
gretay-js Sep 14, 2021
5633c16
Clarify comment
gretay-js Sep 17, 2021
5b872b9
Rename Effects_and_coeffects constructor to avoid confusion
gretay-js Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify comment
  • Loading branch information
@gretay-js
gretay-js committed Sep 17, 2021
commit 5633c1644890d85f0ff6c36dd77dbb153341ce90
2 changes: 1 addition & 1 deletion backend/selectgen.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ method is_simple_expr = function
| Csequence(e1, e2) -> self#is_simple_expr e1 && self#is_simple_expr e2
| Cop(op, args, _) ->
begin match op with
(* Cextcall without effects and coeffects is simple
(* Cextcall with neither effects nor coeffects is simple
if its arguments are *)
| Cextcall { effects = No_effects; coeffects = No_coeffects; } ->
List.for_all self#is_simple_expr args
Expand Down