Unarization for Flambda 2 (unboxed products) #1250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshinwell
requested review from
lpw25,
antalsz,
lukemaurer,
lthls,
chambart,
Gbury,
poechsel,
gretay-js and
xclerc
as code owners
This was
linked to
issues
Mar 23, 2023
mshinwell
force-pushed
the
flambda2-unarization
branch
2 times, most recently
from
bd0dfa0 to
41a4e45
Compare
|
(This is based on PR1241) |
mshinwell
force-pushed
the
flambda2-unarization
branch
from
b6f1d07 to
f415326
Compare
mshinwell
force-pushed
the
flambda2-unarization
branch
from
5ef2213 to
2724144
Compare
mshinwell
force-pushed
the
flambda2-unarization
branch
from
a30d37f to
57efe8f
Compare
|
Now rebased on PR1241 |
mshinwell
force-pushed
the
flambda2-unarization
branch
from
57efe8f to
14598eb
Compare
mshinwell
requested review from
ccasin,
goldfirere and
ncik-roberts
as code owners
|
Superceded by #1433 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unboxed products are split during
Lambda_to_flambda. This PR also includes a rewrite ofFlambda_aritysuch that it can carry unboxed arities all the way through, enabling them to be used e.g. to optimizecaml_applywhen an unboxed product is present.A frontend hack is present to expose some primitives and get layouts correct on
Lletexpressions.There are examples in the
up.mlfile.