Skip to content

Pack import fixes #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lthls
Copy link
Contributor

@lthls lthls commented Jan 10, 2023

All opam packages using packs have been broken for a while (some of them since #871 has been merged). With this PR, we can finally compile most of the previously failing packages.
I think the code is still wrong in a few corner cases; I've left a CR though, and if someone knows how to fix them properly we should do it.

@lthls lthls requested a review from mshinwell as a code owner January 10, 2023 17:47
@mshinwell
Copy link
Collaborator

@lukemaurer could you please look at this?

@mshinwell mshinwell added the bug Something isn't working label Jan 10, 2023
@mshinwell mshinwell linked an issue Jan 10, 2023 that may be closed by this pull request
@mshinwell mshinwell linked an issue Jan 10, 2023 that may be closed by this pull request
@lthls
Copy link
Contributor Author

lthls commented Jan 12, 2023

It would be nice if we could get this merged before the week-end, so that we have updated opam health checks to look at on Monday.

@lukemaurer
Copy link
Contributor

I think I made a mistake when I added the ~cmx_name parameter. If the import info we want is exactly what is in the ui, then we don't actually want to take comp_unit and cmx_name as separate parameters to get_unit_info - it should just take comp_unit and then let cmx_name = Compilation_unit.name comp_unit. Then we don't need either change here to get_unit_info - we want to check that ui.ui_unit is exactly comp_unit and the import we want to add (with or without .cmx) is comp_unit.

I think the solution is to have CU.which_cmx_file return the full CU.t rather than just the name. I'll make a PR.

@lukemaurer
Copy link
Contributor

#1069 should have this covered.

@mshinwell
Copy link
Collaborator

Superceded by #1069 which is now merged.

@mshinwell mshinwell closed this Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPAM CI fixes
3 participants