Asmgen changes for Flambda 2 #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I think I have found the problem with the module names -- the library |
|
...although that doesn't actually fix it. Let's leave this minor problem for now. |
|
In "middle_end/flambda2/dune", there is an I am not claiming this explains the issue you reported, but that feels weird. |
|
Yeah I am just investigating further, and I do suspect this might be the source of the problem. I will fix it in the next PR. |
|
And I don't think you can have |
xclerc
approved these changes
Jul 23, 2021
mshinwell
added a commit
to mshinwell/flambda-backend
that referenced
this pull request
Aug 4, 2021
riaqn
added a commit
to riaqn/flambda-backend
that referenced
this pull request
Feb 23, 2023
c703f5f Incorporate upstream comments into type-variable refactor (ocaml-flambda#121) 362ba23 Constrain curry modes to increase along applications (ocaml-flambda#108) b1f0cf9 Simplify the extension handling (ocaml-flambda#114) 4fd53a1 Remove pat_mode from typedtree (ocaml-flambda#105) cf6fcbc Handle attributes on lambdas with locally abstract types (ocaml-flambda#120) 5fa80fe Don't track attributes inside attributes for warning 53 (ocaml-flambda#115) 8a69777 Handle unclosed `[: ... :]` patterns (via `Generic_array` machinery) (ocaml-flambda#117) b0737f4 Add promote-one Makefile target (ocaml-flambda#118) c6ad684 Refactoring and fixes around module lookup (ocaml-flambda#107) b0a6495 Add documentation for global constructor arguments (ocaml-flambda#69) dd79aec Print `nlocal` in the `-d(raw)lambda` output (ocaml-flambda#112) 8035026 Fix `nlocal` in the generated Lambda for list comprehensions (ocaml-flambda#113) afbcdf0 Immutable arrays (ocaml-flambda#47) bfe1490 fix several issues when removing exp_mode (ocaml-flambda#110) 8f46060 Better error message for under-applied functions (ocaml-flambda#74) 27331d8 Consistently use Lmutvar or Lvar in comprehensions (ocaml-flambda#111) 01e965b Skip failing test for now 0131357 Fix test case to use comprehensions_experimental 22a7368 Temporarily disable list comprehensions tests due to locals bug e08377d Make `comprehensions` into `comprehensions_experimental` for now (ocaml-flambda#109) 947cf89 List and array comprehensions (ocaml-flambda#46) bd9e051 remove exp_mode from typedtree (ocaml-flambda#100) a9268d2 Fix misplaced attribute warning when using external parser (and some cleanup) (ocaml-flambda#101) 2b33f24 Refactor toplevel local escape check (ocaml-flambda#104) ed2aec6 Comment functions exported from TyVarEnv. 87838ba Move new variable creation into TyVarEnv. a3f60ab Encapsulate functions that work with tyvars 43d83a6 Prevent possibility of forgetting to re-widen 2f3dd34 Encapsulate context when narrowing type env't d78ff6d Make immediate64 things mode cross (ocaml-flambda#97) aa25ab9 Fix version number (ocaml-flambda#94) d01ffa0 Fix .depend file (ocaml-flambda#93) 942f2ab Bootstrap (ocaml-flambda#92) 05f7e38 Check Menhir version (ocaml-flambda#91) 1569b58 Move the CI jobs from 4.12 to 4.14. (ocaml-flambda#90) git-subtree-dir: ocaml git-subtree-split: c703f5f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the necessary veneer in
Asmgenfor Flambda 2 compilation.I don't understand why the compiler is unable to find
Flambda2.Flambda_backend_intfandFlambda2.Flambda_middle_end. However referencing them via their mangled names works; I think this is a question for another day.