Skip to content

Conversation

@sabine
Copy link

@sabine sabine commented Aug 28, 2025

We intend to use this in the https://github.com/ocaml/ocaml.org GitHub Actions

Copy link
Collaborator

@shym shym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that PR, very good idea!
I have a small question.

@shym shym force-pushed the add_version_parameter branch from 8d90b50 to 8b69330 Compare September 1, 2025 12:06
@shym
Copy link
Collaborator

shym commented Sep 1, 2025

I rebased (with quite some rewrite 😅) on main.

shym added 2 commits September 4, 2025 12:04
Co-authored by @sabine

Signed-off-by: Samuel Hym <samuel@tarides.com>
Signed-off-by: Samuel Hym <samuel@tarides.com>
@shym shym force-pushed the add_version_parameter branch from 8b69330 to 3e766d0 Compare September 4, 2025 10:04
@shym shym merged commit 184ad46 into ocaml-dune:main Sep 4, 2025
7 checks passed
@sabine
Copy link
Author

sabine commented Sep 9, 2025

Thank you @shym, I didn't manage to keep up with things, and having this feature now is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants