Skip to content

ocaml-migrate-parsetree.2.2.0+stock fails to compile with ocaml.5.00.0+trunk #262

Open
@shubhamkumar13

Description

@shubhamkumar13

OCaml.5.00.0+trunk doesn't work with the current ocaml-migrate-parsetree.2.2.0+stock and logs out the following error

#=== ERROR while compiling ocaml-migrate-parsetree.2.2.0+stock ================#
# context              2.0.10 | linux/x86_64 | ocaml-base-compiler.5.00.0+trunk | file:///drone/src/dependencies
# path                 /drone/src/_opam/5.00.0+trunk/.opam-switch/build/ocaml-migrate-parsetree.2.2.0+stock
# command              /drone/src/_opam/5.00.0+trunk/bin/dune build -p ocaml-migrate-parsetree -j 47
# exit-code            1
# env-file             /drone/src/_opam/log/ocaml-migrate-parsetree-29772-0d22b9.env
# output-file          /drone/src/_opam/log/ocaml-migrate-parsetree-29772-0d22b9.out
### output ###
#        ocaml src/ast-version (exit 1)
# (cd _build/default/src && /drone/src/_opam/5.00.0+trunk/bin/ocaml config/gen.ml 5.00.0+dev0-2021-11-05)
# Unknown OCaml version 5.00.0+dev0-2021-11-05

and since the current trunk's ast is not frozen it's best to wait for trunk to be frozen and then create a new ppxlib branch to work with OCaml.5.00.0+trunk in sandmark (since ocaml-migrate-parsetree is not needed for 5.0).

This would temporarily result in failure of a couple of irmin benchmarks

File "benchmarks/irmin/dune", line 4, characters 18-27:
	4 | 	(libraries irmin irmin.mem lwt lwt.unix))
	                      ^^^^^^^^^
	Error: Library "irmin.mem" not found.
	Hint: try:
	  dune external-lib-deps --missing --profile release --workspace ocaml-versions/.workspace.5.00.0+trunk @buildbench
File "benchmarks/irmin/dune", line 9, characters 118-123:
	9 | 	(libraries ppx_deriving_yojson.runtime irmin-pack irmin-pack.layered irmin-layers index fmt logs lwt lwt.unix yojson irmin unix cmdliner))
	                                                                                                                          ^^^^^
	Error: Library "irmin" not found.
	Hint: try:
	  dune external-lib-deps --missing --profile release --workspace ocaml-versions/.workspace.5.00.0+trunk @buildbench
	      ocamlc benchmarks/yojson/.ydump.eobjs/byte/dune__exe__Ydump.{cmi,cmo,cmt} [5.00.0+trunk_1]

Hence it seems best to currently track the benchmark failures in #261
and fix it when 5.0's AST is frozen.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions