Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1563-Start Block Is Not Generated At The Top Left Of The Window #1566 #1568

Conversation

AbdelrahmanDeghedy
Copy link
Contributor

@AbdelrahmanDeghedy AbdelrahmanDeghedy commented Jan 14, 2024

Description

  • This is a fix to this issue.
  • It was done by always moving the start block to the fixed position (100, 100) (instead of the previous behavior of generating it in random positions based on the variable i, which is a global variable that changes by the for loops inside the code).

How Has This Been Tested?

Screencast.from.14-01-24.09.19.29.webm

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AbdelrahmanDeghedy)

@faucomte97 faucomte97 merged commit 17149ce into ocadotechnology:master Jan 16, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants