remove unused six import #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Hey @obynio. Thank you so much for keeping this plugin up. Any chance you would have some bandwidth to review/merge the PR and release a new version of the plugin 🙏 |
|
Anyone who uses NPM and Gandi is hitting this issue every 90 days where certs won't renew, causing all their services to fail. I'm on Round 2 myself. @obynio It would be super great and you'd be helping out a lot of people if you could review/merge the PR. Thank you so much. |
|
I've forked and published my own "modern" variant here: https://github.com/Kriechi/certbot-plugin-gandi-modern You can download and install it using: Please provide feedback and file new issues at my fork directly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #49
It seems the certbot Docker image recently removed the six library, and now the certbot-plugin-gandi crashes due to this unused import statement.