Add MouseCursor::pos and fix move_rel and mov_abs #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #16.
Not sure if the name is good. Maybe
get_pos
would be better?Also, the
MouseCursor
functions takingself
is a bit awkward. Maybe it would be better to just make them associated methods? Or at least make itCopy
?Edit: Also, I'm using
MaybeUninit
since I saw it used somewhere else in the code but I just realized that the other place is usingMaybeUninit::zeroed
. I think it should be safe as is and maybe even slightly better for performance (although the difference is probably minimal) but if you want I can change it. Also, maybe it would be clearer (and work in earlier Rust versions?) to usestd::mem::zeroed()
?Edit2: Closes #16