UI: Use C++11 ranged-for instead of Q_FOREACH

[RytoEX]

Description

Qt has been porting uses of Q_FOREACH/foreach to C++11's ranged-for. Let's do the same.

References:

• https://bugreports.qt.io/browse/QTBUG-115796
• https://doc.qt.io/qt-6/foreach-keyword.html
• https://codereview.qt-project.org/q/Q_FOREACH
• https://en.cppreference.com/w/cpp/language/range-for

Motivation and Context

We target C++17. Q_FOREACH was previously suggested to be deprecated/replaced for Qt 6. While that did not happen, Qt's efforts to replace Q_FOREACH/foreach indicate that its days may be numbered.

How Has This Been Tested?

Built and ran OBS on Windows 11. Invoked the Reset Stats hotkey a few times.

Types of changes

• Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[gxalpha]

Good change.
Personally I’d at curly braces to the for-loop.

[derrod]

Might as well skip the variable assignment and go straight for

	for (OBSBasicStats *s : findChildren<OBSBasicStats *>())
		s->Reset();

But they're functionally equivalent.

[RytoEX]

I added the curly braces for the for loop (I usually prefer this anyway), but left in the variable assignment. While the assembly in Visual Studio seemed basically identical in Debug, removing the assignment produced about twice as much assembly in RelWithDebInfo. If there's an optimization to be made here by removing the assignment, maybe someone can revisit that in the future. For now, let's just let the compilers do their own thing