Skip to content

Conversation

dsaedtler
Copy link
Contributor

Description

Changes the saving logic a bit so that scenes from canvases not managed by the frontend won't get saved.

Also refactors the saving a bit since the separate GenerateSaveData() seems unnecessary.

Motivation and Context

The intention was that the frontend should only save and load canvases it manages (i.e. created via the frontend API). Likewise it shouldn't save any scenes on canvases that aren't frontend-managed or ephemeral.

This problem was reported on Discord.

How Has This Been Tested?

Saved and loaded some scene collections.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality Code Cleanup Non-breaking change which makes code smaller or more readable labels Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Code Cleanup Non-breaking change which makes code smaller or more readable Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants