Fix display/window capture on Windows capturing on creation #11233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to the property view widget not having an item to select, so it selects the first one, but we want to have specific text for this anyway, so changing it here is still appropriate. (I don't want to touch the properties view widget right now for the sake of my sanity)
Prevents Display capture from capturing the first display on creation. This issue is due to the properties view combo box automatically selecting the first item in the list by default, but this needs explicit text anyway to indicate display, so this adds a "[Select a display]" item that will prevent that from happening and tell the user to select a display.
WizardCM
added
Enhancement
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where window and display capture on Windows would capture the first window or display on first creation. This is actually due to a design flaw in the properties view, but we need to fix it in the sources themselves to display the appropriate text to the user anyway.
Motivation and Context
It's not good to capture something without explicitly selecting it.
How Has This Been Tested?
Tested locally, seems fine.
Types of changes
Checklist: