Browser docks now works under wayland when I revert the disable

[neolectron]

Operating System Info

Ubuntu 22.10

OBS Studio Version

Git

OBS Studio Log URL

https://obsproject.com/logs/4WXvjRYBshjkFrRA

Expected Behavior

Expected behavior would be to NOT work without the temporary commit that disable custom browser docks on wayland.

Current Behavior

It DOES work, therefore the disabling of custom browser docks is useless.

Steps to Reproduce

1. Clone OBS-studio.
2. Revert commit 7402271392a6a74fb49f16d84fb3c04c1b603d9a in obs-browser.
3. Build from source.
4. Start OBS with qt (for X): GDK_BACKEND=x11 QT_QPA_PLATFORM=xcb obs.
5. Custom browser docks works.

Anything else we should know?

(I tested it on Arch and the last ubuntu, they both worked)

[tytan652]

GDK_BACKEND=x11 QT_QPA_PLATFORM=xcb obs

Session Type: wayland
Window System: X11.0, Vendor: The X.Org Foundation, Version: 1.23.1

You are under XWayland so an X11 implementation, not Wayland.

[neolectron]

@tytan652 yes but that's still the only way to make the browser-docks appear when your host session is wayland.

If I had only ran the obs in xwayland, screen-capture wouldn't work.
It works with pipewire AND xwayland.
(and that's the only way to get it to work afaik)

[tytan652]

This is not Wayland (Wayland backends, no XWayland).

Also we do not support running under XWayland.

[neolectron]

Let's not focus on the semantics, but rather on the results.

Is there any other way to have both screen-capture AND browser-docks working on wayland at the current time, that I might not be aware of ?

If no, I don't really get why we would like to prevent users to run their OBS like so.
Thanks.

[tiberium-v]

Browser Docks are disable on wayland because of a CEF bug/limitation. That's why obs prevent the creation it on wayland.

[notAutomne]

Hello,

I fully agree with @neolectron. It's rather :

• Losing a feature
• Having a feature with a minor workaround

Having to recompile OBS just to get a feature that can work only with an argument in startup seems a biggest issue for the user.

The safest option is just to add a messagebox if the user tries to launch browser-docks without delegating to XWayland.

[tytan652]

Let's not focus on the semantics, but rather on the results.

The result is: it works under X11 (XWayland is one of its implementation), not Wayland.

I repeat:

• We do not support running under XWayland.

[notAutomne]

Let's not focus on the semantics, but rather on the results.

The result is: it works under X11 (XWayland is one of its implementation), not Wayland.

I repeat:

* We do not support running under XWayland.

Not supporting is a thing. Preventing to use OBS in a unsupported way with the user consent is another.

It should be denied but not at compile time but rather with a simple check at runtime.

[notAutomne]

Any statement on this conflict @jp9000 @jpark37 ?

[neolectron]

@tiberium-v, I get what you mean, but the limitation is no-more.

@tytan652:

The result is: it works under X11 (XWayland is one of its implementation), not Wayland.

Okay but it still makes use of pipewire for screen-capture, which WAS NOT possible without the reverted commit. You couldn't have BOTH screen cap AND browser-docks before.

I was under the impression that the commit I reverted was initially temporary, as it was stated in the commit description made by jp in 2021.

Since this particular commit doesn't really fix or prevent any crash anymore, I don't see why you would like to keep it.

c7aacea

Also there's some additional details I would like to give.

If you start OBS without the flags, OBS works, but browser-docks are disabled, so there's NO issue (we stay in the same exact state as today - aka 0 impact).

If you start with the flags, it also add the browser-docks to the already working OBS setup (with pipewire screen-capture etc.)

[benstigsen]

Are there any updates on this?
I have been able to find several CEF Wayland specific issues on the Chromium tracker, but I'm not sure which one is relevant to this case.

[WizardCM]

Are there any updates on this? I have been able to find several CEF Wayland specific issues on the Chromium tracker, but I'm not sure which one is relevant to this case.

You can track chromiumembedded/cef#2804