Skip to content

Conversation

@Penwy
Copy link
Contributor

@Penwy Penwy commented Jan 6, 2026

Description

This lets the analyzer properly handle the lack of an identifiable OBS version line, and report it as "Unparseable version" instead of erroring out.
This is done by propagating the None into the version parser, which will be processed as unparseable.

Motivation and Context

Analyzer errors out if no obs version line is found.

How Has This Been Tested?

Ran on a log without any version line, noticed correct print instead of error.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine, but I'll let this sit overnight in case someone sees a reason this should not be merged.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: obs -> OBS

@RytoEX RytoEX changed the title checks: Properly handle lack of obs version checks: Properly handle lack of OBS version Jan 7, 2026
@RytoEX RytoEX merged commit c66b8c0 into obsproject:master Jan 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants