Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ru translate #524

Merged
merged 3 commits into from
Jul 31, 2021
Merged

Update ru translate #524

merged 3 commits into from
Jul 31, 2021

Conversation

AVAtarMod
Copy link
Contributor

@AVAtarMod AVAtarMod commented Jul 24, 2021

I think "Встроенные плагины" more accurate than "Основные плагины"
Changes should be reviewed as I neither have Obsidian Publish nor Obsidian Sync enabled and thus am missing context for some translations (as and DE pull request author, because he not have that services too)

@ericaxu
Copy link
Contributor

ericaxu commented Jul 24, 2021

@AVAtarMod do you want to find someone to review it? If you're on Discord, the Russian channel might help.

@AVAtarMod
Copy link
Contributor Author

@ericaxu Thanks, I'll go to channel which you described.

Copy link
Contributor

@lisachev lisachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping the community. You are welcome to discuss the translation on the Telegram channel. The link is in the ru.termbase file. If you are not on the telegram platform, please let me know and I will review the whole submission here.
There are some nuances. For example plurals dont work like you expect them to. For Russian we are forced to use : as a workaround. Look at other translations of plurals.
Core plugins are not embedded. They are still plugins, they just come with the application itself. I would not change the naming. But again - you are welcome to discuss it with other translators in telegram if you like to.

@AVAtarMod
Copy link
Contributor Author

Thank you for help and review my PR, I did little fixes of the translate.

Copy link
Contributor

@JxhnnyUt8h JxhnnyUt8h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericaxu can be merged from now 😎

@ericaxu
Copy link
Contributor

ericaxu commented Jul 31, 2021

Thank you so much! <3

@ericaxu ericaxu merged commit 2a7dd3b into obsidianmd:master Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants