Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean docs #602

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Update Korean docs #602

merged 5 commits into from
Jan 12, 2024

Conversation

cherojeong
Copy link
Contributor

@cherojeong cherojeong commented Oct 15, 2023

I've translated entire docs as Korean in obsidian-help, To keep consistency with English Heading and File Name (.md) , I kept Heading and File name as English. It would be better to find and translate from English doc's updated contents later and make internal links with heading.

  • Added ko language to README.md
  • kept Credits document as English.

When I checked obsidian-translation repository, there is ko.json file waiting one of pull requests.
for example. translation of "publish" can be "게시" instead of "출판" in some of cases. it is more precise. but it is not updated yet. so my translation was done based on current translation as "출판". In korean , publish word can be taken either releasing the book or showing the contents on website or something like that.

@sigrunixia
Copy link
Contributor

Hello @cherojeong

Do you have any more updates you want to add before this is merged in?

@sigrunixia sigrunixia self-assigned this Jan 5, 2024
@cherojeong
Copy link
Contributor Author

Hello sigrunixia

No I don't have it. If there is no issue to merge in master, when it would be merged in ? but If there is something to add on your side. please let me know

@sigrunixia
Copy link
Contributor

It will be merged... right now! Muahahaha. 👀

@sigrunixia sigrunixia merged commit 91eee84 into obsidianmd:master Jan 12, 2024
@sigrunixia
Copy link
Contributor

And as an update, @cherojeong, the site is now published. https://publish.obsidian.md/help-ko/Home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants