-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker: Move docker setup into docs #647
Conversation
@claremacrae I moved the docker stuff into |
On Mac when I run
|
|
Hi @schemar Sorry to be the bearer of bad news, but this is a regression for me - I can no longer run the docs locally. I've got my previous version on the branch for the current PR so that will do for now. |
- It is converted to HTML via Ruby and Jekyll | ||
- Important: Ruby 2 is required, for example, Ruby 2.7 | ||
- The published documentation is at <https://schemar.github.io/obsidian-tasks/> | ||
- For background, including which branch to work on, see ["Updating documentation" in CONTRIBUTING](../CONTRIBUTING.md#updating-documentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered where these extra spaces were coming from.
There's a curious cycle going on that your edits include extra spaces in bullet lists, and then @sytone (and I think mine) remove them.
It's is only cosmetic, but it does make git annotate/blame rather less useful, and makes reviews take longer, as you have to mentally separate out formatting changes from content ones...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's my LSP based md formatter 🤔
Hm, weird. Sorry. Did it first build the image? Can you try removing the |
The last line should only read |
I may have run into a podman feature that doesn't exist in docker. |
One thing I was curious about is whether the script defaults to always using the local version of the docs. I was curious about what the tag did…. |
Just curious... What was the motivation for the reworking of the scripts? |
(I mean more than changing the paths due to different working directory...) |
OK That fixed it. Brilliant - thank you very much! I'm back in business! 🎉 I'll create a tiny PR to push that change... --volume "$PWD:/docs:Z" \
--publish 4000:4000 \
- "localhost/${TAG}"
+ "${TAG}" |
Answering my own question: yes, it does pick up changes in the local directory... 🎉 |
This enables docker_start to run on my Mac. See obsidian-tasks-group#647.
This enables docker_start to run on my Mac. See #647.
Yeah. For this simple use case, docker compose is not really necessary. It's just a container with a mounted volume. Docker compose is not necessarily part of a docker install and may be an additional dependency. |
Thank you. That's good to know. |
This enables docker_start to run on my Mac. See obsidian-tasks-group#647.
Fixes #646