feat: support pulling from cloudwatch metrics #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-zhu
reviewed
Mar 7, 2023
| variable "filters" { | ||
| description = "List of filters." | ||
| type = list(object({ | ||
| namespace = string |
There was a problem hiding this comment.
Yes. The rationale here is that polling is a cost sensitive measure, and so the API should nudge people towards being specific. If you want a wildcard, you might as well configure a cloudwatch metrics stream.
luke-zhu
approved these changes
Mar 7, 2023
bendrucker
approved these changes
Mar 8, 2023
jta
pushed a commit
that referenced
this pull request
Mar 8, 2023
This commit addresses nits uncovered in #58 which were also applicable to the snapshot module.
bendrucker
approved these changes
Mar 8, 2023
jta
pushed a commit
that referenced
this pull request
Mar 8, 2023
This commit addresses nits uncovered in #58 which were also applicable to the snapshot module.
This commit introduces a new submodule, `cloudwatch_metrics`. Similar to our API snapshot functionality, we set up a eventbridge rule that periodically triggers the lambda with a custom payload. This payload tells the lambda what metrics to scrape for. Callers of this module can configure metric collection through the `period`, `interval`, `delay` and `filters` variables. Users must provide a list of filters. Each filter must have a namespace, and an optional set of metric names and dimensions. Co-authored-by: Ben Drucker <bvdrucker@gmail.com>
jta
pushed a commit
that referenced
this pull request
Mar 8, 2023
This commit addresses nits uncovered in #58 which were also applicable to the snapshot module.
jta
pushed a commit
that referenced
this pull request
Mar 9, 2023
This commit addresses nits uncovered in #58 which were also applicable to the snapshot module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new submodule,
cloudwatch_metrics. Similar to our API snapshot functionality, we set up a eventbridge rule that periodically triggers the lambda with a custom payload.This payload tells the lambda what metrics to scrape for. Callers of this module can configure metric collection through the
period,interval,delayandfiltersvariables.Users must provide a list of filters. Each filter must have a namespace, and an optional set of metric names and dimensions.