Remove .columns #365
Merged
Remove .columns #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2023 12:07
libbey-observable
approved these changes
Apr 28, 2023
Contributor
libbey-observable
left a comment
libbey-observable
left a comment
There was a problem hiding this comment.
These changes look good to me. If a source comes in to __table() with .columns and thus passes through and gets returned with .columns, that seems okay to me, but if we want to dig in deeper on that I'd be up for that, too.
Contributor
Author
|
yep that makes sense to me! thinking about it a bit more, there could be any number of properties on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Based on a suggestion from Mike)
Remove .columns from
__table. It's no longer needed since we always guarantee that we'll return a .schema, and .schema is a superset of the information in .columns.One thing I'm not too sure about – if the source has a .columns property and the source isn't modified in
__table, the .columns property will pass through and remain in the output. Is that ok, or do we need to standardize__tableby making sure .schema is the only property on the output?